tolsen64 on 26/6/2011 at 04:20

---

v11.6.25.1
Fixed a bug reported by gnartsch. SS2 Zygo Arena would crash during install.
Fixed a bug found while fixing the other bug (copied game files to the root directory of the installed games instead of the game directory).

You can now download just the executable if you don't need everything.

(https://github.com/tolsen64/TFMM-fmsel/blob/master/Release.7z) https://github.com/tolsen64/TFMM-fmsel/blob/master/Release.7z

gnartsch on 26/6/2011 at 11:28

---

Thanks for the fix ! Works fine now.

I just did some testing for Thief2 ... and I have a couple of problems to report :(
Some info upfront: my OS is german, but Thief 2 is english.
Running on Win7 64 bit.

1. Exception when quitting a T2-mission
This happens for all T2 missions I have tried.
Odd enough: for SS2 this error does not appear.
It basicly says that an exception occurred while converting the string "The_saves.zip" into type Double.
Here are the details (sorry for providing the german message, but I hope it has enough information anyway):



2. Problems when no default language is not availlable
I tried an old version of 'Vol De Nuit'/'Night Flight' by 'TheHardy Boyz'
While the mission was installed, the objectives were entirely empty and readables would have shown no text either.
Note that that old version exclusively supports french as language with all resources located in 'french'-folder. The zip for it can be found (http://www.keepofmetalandgold.com/missionst2/VolDeNuit_FR.zip) here.
Also I think it would be good to allow the user to pick a specific language e.g. for testing purposes or due to personal preferences.
DarkLoader e.g. identifies the possible languages correct and also allows to pick a language.

EDIT: I guess this means in general: if there is a multilanguage-FM (using language specific resource folders), but YOUR language is not supported, then you can not use TFMM, because all resources won't be installed.

3. Misbehaviour of 'Clear All Settings' in the TFMM Setup dialog
When pushing the 'Clear All Settings'-button, then the 'Target Game Directory' should be cleared as well.
Here is what I did (see the screenshot to follow the steps):
a. Push 'Clear All Settings'
b. Note that the 'Target Game Directory' is still set
c. Add back the Game and FM Directories
Note: At this point you can even proceed with getting the Info for the FM's and Install it !!
d. Close TFMM and reopen it. Now the 'Target Game Directory' is empty
http://www.gnartsch.de/Thief-FM/beta/TFMM/ClearAll.png

4. Tools not properly disabled
See the following screenshot:
http://www.gnartsch.de/Thief-FM/beta/TFMM/Tools.png
There I have only SS2 configured. But the Tools for T1 & T2 are enabled.
For T3 it is slightly different: That option is only grayed out, but not disabled. Therfore the sub-items are still active.

5. Identifying Game Type
I have all T2 missions and demos that are out there and I added all of them to TFMM.
I think the recognition has some flaws and for sure should NOT DEFAULT to T1 in case there are any issues.
See this screenshot: http://www.gnartsch.de/Thief-FM/beta/TFMM/T2-Demo.png
Intruders (http://thiefmissions.com/info.cgi?m=KeeperInvestigations) 'Keeper Investigations'-Campaign is recognized as T1 ! But it is clearly T2 !

Also note the other ZIPs that are highlighted. They are all demos for T2 and most of them contain no .MIS-file (instead they have just a COW file inside, which would only run in DromED).
Even more: even ZIPs with just a readme and two *.avi file are recognized as T1.

My take on this:
- files without a .gam, .mis or .cow should not be displayed at all
- for files with no .mis but with a .cow, the type should either be left blank or set to 'DromEd'
- in case the type can not be identified, then better leave it blank or set to 'Unknown'. Better make the user aware of this and force him to decide on his own instead of providing a default which most probably will just cause crashes and confusion.

6. Two missions with incompatible ZIP format
I added all 1200 missions I know of (incl. SS2, T1, TG, T2, TDS) and checked if they are all recognized and can be installed in principle.
2 gave errors on the ZIP level:
(http://thiefmissions.com/info.cgi?m=sworddrkl) T1 - Sword of Drakul (Michael Webb)
(http://thiefmissions.com/info.cgi?m=UninvitedGuests) T1 - UninvitedGuests (Shock Troop)
Note that DarkLoader is able to install them all right. So the ZIP is not entirely *broken*.
Seems to be due to some non-standard ZIP format.
People might as well unpack and rezip these missions themselves.

gnartsch on 26/6/2011 at 15:19

---

I added another issue in the list above (6.).

Regarding the crash when you quit a FM:
call me nuts, but I can't get any sense into it.

Yet there is a schema:
-if I quit from a T2 mission, it says
"Could not convert string The_saves.zip to Double"
-if I quit from a Thief1/Thief Gold mission, then the message reads
"Could not convert string The_demo_saves.zip to Double"
- no such problems with TDS or SS2

No idea where the additional _demo_ comes from for T1 compared to T2.
None of the FMs has it in the name nor does the folder name include it.
I tried with at least 5 Fms of each type. It's always the same.

All games are off course located on the same drive and work fine.
And I cleared the TFMM-database a couple of times as well.
So, there should be no old chunk left over.


EDIT: my last attempt for today trying to understand the root cause.
Here is what I did:
- make sure the latest version of TFMM is installed and exit it
- drop the TFMM.mdb and make sure to replace it with the fresh one shipping with TFMM
- start TFMM
- configure only Thief 1 and add only one folder for it
- get the info for one mission and install it
- push 'Play Mission', start the FM and create a savegame (or don't save - that doesn't seem to matter)
- Quit Thief1 and see the error popping up

http://www.gnartsch.de/Thief-FM/beta/TFMM/OddCrashOnQuit.png

I don't get it.



EDIT:
Ok. Seems like 11.6.26.2 fixed the problem.
Odd. But thanks !


EDIT:
Hmmmm... using a text-editor I had a look at the 'clean' TFMM.mdb shipping with the program.
Maybe it would make sense to provide an entirely empty version of that file?
One can still see all FMs you had installed on drive F and I see 9 occurrences of The_demo.zip and 100 (!!) occurrences of The.zip.
These names would explain The_demo_saves.zip and The_saves.zip that I saw.
Even if that does not show up when opening the database and this 'crap' is just filled into the mdb-file in order to fill up the specified field-length,
then there still must be some code in TFMM producing them.

tolsen64 on 26/6/2011 at 23:08

---

I think I have this fixed.



I think I have this fixed.



I think I have this fixed as well. However, I still need to add a dialog for the user to "make playable" for any that are deemed invalid.

I did not delete non-mission files from the database because next time you synchronize they will re-appear.

Download the (https://github.com/tolsen64/TFMM-fmsel/blob/master/Release.7z) executable only from the web site and let me know if these items are fixed. I haven't updated the full archive as I still have more work to do, just out of time today.

gnartsch on 27/6/2011 at 18:58

---

Hi tolsen64,

some feedback on the latest EXE. Oh dear, I am afraid you did too much !

1. TDS-missions are no longer recognized !
They have no Game Type set and status reads 'Not a mission file'

2. ZIP's where the name of .gam file does not match the name of the .mis file are reported as 'Only has .gam file'.
Since it is perfectly up to the author how to name the .gam-file, you should not spend too much logic in finding a correlation.
e.g. Zombe by Mikhel Tsäko and Ancient by Jason Free (SS2) and 3 T2 demo-missions as well
So, this 'warning' is rather misleading and confusing.
And installing them should be allowed without restrictions.

3. ZIP's without .gam, but with .mis files are reported as 'Not a mission file' and no Game type is set.
Note that an author can choose to simply use whatever .gam comes with the game itself.
So, an existing .gam file in the ZIP is for sure no requirement.
e.g. Arboretum by Thomas Greene and DojoLevel by Zygoptera (SS2)

Since I do not know the code I have to guess what is going wrong.
But for sure these were recognized correctly in the previous version.
So, see the missions I mentioned as examples.


The good news:
- I now see intruders KeeperInvestigation now being reported as T2
- and all T2-demos running only in DromEd seem no longer be reported as T1
- and all the random ZIPs without a mission inside say 'Not a mission file'
- Tools menu is fixed
- 'Clear all Settings' as well

Good !



A minor crash and something else : (can be fixed in 12.x or later :cheeky:)

1. Make TFMM crash
- Select a couple of files and initiate 'Get File Information'
- After a few files were examinated, cancel the dialog with the 'close-window'-button in the top-right
- Initiate 'Get File Information' again
- When it gets about to the last file that got examined already, it will crash

2. Concurrent update of FM Info
- Select a couple of files and initiate 'Get File Information'
- initiate 'Get File Information' again
- now 2 Dialogs are open !
- also it seems there is a chance that the second one catches up with the first, which results in a crash as well

:D

I have the latest exe and checked for updates. It says a new version is availlable.
Just kidding ... since in general the version on the website should be the latest, off course.
Anyway, would there be a chance to simply display what the new version number is in the dialog ?
Or do an automatic check right on startup (with the option to disable automatic checking) ?